search

chartjs / chartjs-plugin-annotation

Annotation plugin for Chart.js
MIT License
607 stars 328 forks source link

Workaround for array syntax bug with Chart.js<v3.7 #575

Closed kurkle closed 2 years ago

stockiNail commented 2 years ago

@kurkle just for my info. PR 555 will require Chartjs 3.7. If and when the PR will be merged, should this workaround be removed because there will be a strong dependency with 3.7? If yes, maybe makes sense to add a TODO.

kurkle commented 2 years ago

@kurkle just for my info. PR 555 will require Chartjs 3.7. If and when the PR will be merged, should this workaround be removed because there will be a strong dependency with 3.7? If yes, maybe makes sense to add a TODO.

Yes that could make sense. I'm not sure at which version of the plugin should we require Chart.js v3.7, but the comment does not need to include a plugin version.