search

chartjs / chartjs-plugin-annotation

Annotation plugin for Chart.js
MIT License
607 stars 328 forks source link

Change enabled to display option in all nodes of annotations #703

Closed stockiNail closed 2 years ago

stockiNail commented 2 years ago

Fix #594.

This PR normalizes the option to display or not the nodes of the annotations. Use display instead of enabled.

kurkle commented 2 years ago

Migration should be made easy, so we need to start a migration guide for v2 when we start merging these changes.

stockiNail commented 2 years ago

Migration should be made easy, so we need to start a migration guide for v2 when we start merging these changes.

Yeah! What about a specific doc page (in guide section)? it could be the first PR to merge for version 2 and all the others should be adapted in order to add the right documentation about changes.

stockiNail commented 2 years ago

Thank you very much @kurkle. Slowly but surely I'm going on with the normalization PR, which needs a big rebase!