search

chartjs / chartjs-plugin-annotation

Annotation plugin for Chart.js
MIT License
607 stars 328 forks source link

Replace deprecated String.prototype.substr() #711

Closed CommanderRoot closed 2 years ago

CommanderRoot commented 2 years ago

String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated. .substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.

kurkle commented 2 years ago

Merged as this was not a breaking change. If we decide to release another minor for v1, the milestone of this pr needs to be updated.

stockiNail commented 2 years ago

@kurkle I have seen that this PR created a release note 1.4.1 even if tagged as 2.0.0: https://github.com/chartjs/chartjs-plugin-annotation/releases/tag/untagged-e554510da7259acef101

I don't know if this is correct and a normal behavior.

kurkle commented 2 years ago

release-drafter determines the version based on version resolver config: https://github.com/chartjs/chartjs-plugin-annotation/blob/67989c8164c3644523123cbfc098198be638e2db/.github/release-drafter.yml#L28-L40

so unless its a major or minor, its a patch :)

it will update after new commits are added.

stockiNail commented 2 years ago

@kurkle thank you very much for explanation and apologize for this stupid question. I'm still trying to understand how it works all GHA in place for this project.

kurkle commented 2 years ago

https://en.wikipedia.org/wiki/No_such_thing_as_a_stupid_question