search

chartjs / chartjs-plugin-annotation

Annotation plugin for Chart.js
MIT License
603 stars 325 forks source link

Move interaction object at top level of plugin options #736

Closed stockiNail closed 2 years ago

stockiNail commented 2 years ago

The interaction object has been moved at top level of plugin options, instead of common object as implemented by PR #630.

This is because the interaction is not configurable at annotation instance but is a plugin configuration, like clip one.

stockiNail commented 2 years ago

Not sure if this has an impact on the resolution of options, but probably not,

I don't think so because interaction can not be set at annotation level, like clip.

stockiNail commented 2 years ago

Not sure if this has an impact on the resolution of options, but probably not,

@kurkle I have tested locally (even if I was almost sure) that interaction is falling back to chart options interaction if missing.