search

chartjs / chartjs-plugin-annotation

Annotation plugin for Chart.js
MIT License
603 stars 325 forks source link

Remove label clipping to box annotation size #764

Closed stockiNail closed 2 years ago

stockiNail commented 2 years ago

This PR is remove label clipping to box annotation size.

stockiNail commented 2 years ago

@LeeLenaleee after merging this one, do you think we will bump to version 2?

LeeLenaleee commented 2 years ago

No, I am currently looking into moving project to TS, so if you give me till next week wednesday to see if I can make some progress on it. If I dont have made any progess after that we can merge it, else I want to try and switch to TS first.

Made a quick start on it but need to check things out since types dont match up so its a bit of research work

stockiNail commented 2 years ago

No, I am currently looking into moving project to TS, so if you give me till next week wednesday to see if I can make some progress on it. If I dont have made any progess after that we can merge it, else I want to try and switch to TS first.

No hurry, so take your time.

stockiNail commented 2 years ago

I hope to be able to continue contributing in TS because I don't know much about it :pensive:

stockiNail commented 2 years ago

@LeeLenaleee I was thinking if it is not better to have a frozen situation before going to TS, merging all pending PR. This could avoid a double and complex work on those PR

LeeLenaleee commented 2 years ago

hmmm yeah I guess, well lets release V2 and make it something for later then, its a nice bit of research work with how everything exactly works so it will take some time to do it, would be better for next major version

stockiNail commented 2 years ago

@LeeLenaleee do you want I try creating bump PR?

LeeLenaleee commented 2 years ago

Yeah sure 👍🏻