Enable different fonts and colors configuration on multiline labels - Githubissues

chartjs / chartjs-plugin-annotation

Annotation plugin for Chart.js

MIT License

606 stars 328 forks source link

Enable different fonts and colors configuration on multiline labels #801

Closed stockiNail closed 1 year ago

stockiNail commented 2 years ago

fix #739

contentMultilineColors

TODO

[x] test cases
[x] types definitions changes
[x] documentation
[x] samples

kurkle commented 1 year ago

Needs a rebase

stockiNail commented 1 year ago

Needs a rebase

Done but fighting with fixture tests on FF... Don't know why. Locally no issue with the same FF version 110.0

kurkle commented 1 year ago

I'm not able to help this weekend, except on reviews.

stockiNail commented 1 year ago

I'm not able to help this weekend, except on reviews.

No problem. I will leave it as is now. I need to understand better why the fixture tests are all failing only on FF and only in CI (not locally). I'll have a look next week, busy this weekend as well.

kurkle commented 1 year ago

Maybe the animations got enabled for ci?

stockiNail commented 1 year ago

Maybe the animations got enabled for ci?

I don't think so.. I'm thinking (but not sure) it could be related to #851, where the point location calculation changed but it's also weird that I didn't have these errors in that PR.

EDIT rollback the changes where tolerance was added. More investigations are needed

stockiNail commented 1 year ago

No way, even re-saving the image from FF (v110.0, like in CI) and push it. I don't where the issue could be :(

stockiNail commented 1 year ago

@kurkle rebased and CI ended correctly.