search

chartjs / chartjs-plugin-annotation

Annotation plugin for Chart.js
MIT License
603 stars 325 forks source link

Fix init option type setting it as optional #867

Closed stockiNail closed 1 year ago

stockiNail commented 1 year ago

Fix #866

stockiNail commented 1 year ago

@kurkle @LeeLenaleee if the PR is ok for you and then you will approve it, we could release a bug fixing release. What do you think? Too early?

stockiNail commented 1 year ago

Thank you @LeeLenaleee and apologize for the bug. I haven't recognized it due to my poor knowledge on TS :(.

LeeLenaleee commented 1 year ago

Don't you worry mistakes happens to us all, it also slipped by in the review so we are equally to blame, important thing is that it's fixed 👍

kurkle commented 1 year ago

I would suggest releasing bug fixes asap. There are plenty of version numbers to use, so no need to collect weeks or months of work to one (and keep the bug(s) unfixed meanwhile).

stockiNail commented 1 year ago

I would suggest releasing bug fixes asap. There are plenty of version numbers to use, so no need to collect weeks or months of work to one (and keep the bug(s) unfixed meanwhile).

Got it !! (in fact, I had already prepared the bump PR ;)). I'll not ask anymore!

stockiNail commented 1 year ago

@kurkle do you want to release in the next days a version 3 with only PR https://github.com/chartjs/chartjs-plugin-annotation/pull/838 to fix the type=module issue?

kurkle commented 1 year ago

I don't have any objections to that, sounds good.

stockiNail commented 1 year ago

Ok! Let me do some additional tests because I think that the peerDependencies of Chart.js could change.