search

chartjs / chartjs-plugin-annotation

Annotation plugin for Chart.js
MIT License
606 stars 328 forks source link

Fix documentation after setting plugin as module #885

Closed stockiNail closed 1 year ago

stockiNail commented 1 year ago

This Pr should fix the issue related to the documentation where the chart instances are not available because the chart.js elements are not registered.

The issue sounds to be related to vuepress-theme-chartjs and how imports are managed. Not clear to me why (apologize) but adding the import names where missing, the app built by webpack/vue seems to have the registration and is importing everything as it should.

stockiNail commented 1 year ago

@kurkle @LeeLenaleee let me know what you think. Not sure why this update should solve the issue but weirdly the vue app JS is not built correctly if we omit the names of the imports.

stockiNail commented 1 year ago

@kurkle @LeeLenaleee I didn't relate the PR to the issue because I would like to see how it works on GHP before to close the issue.

stockiNail commented 1 year ago

@kurkle @LeeLenaleee I can confirm you that the development version on doc (master) is now rendering the charts.... The problem is that version 3.0.0 is broken :( Let me know if you think we can fix in same way, otherwise we could release version 3.0.1.