chartjs / chartjs-plugin-annotation

Annotation plugin for Chart.js
MIT License
606 stars 328 forks source link

Type error in label.d.ts #907

Open Fordiboii opened 1 year ago

Fordiboii commented 1 year ago

Hello folks, Thanks for the nice plugin. Using chartjs-plugin-annotation: 2.2.1 and typescript: 3.9.10 I get the following type error:

ERROR in .../node_modules/chartjs-plugin-annotation/types/label.d.ts(5,25):
5:25 'number' only refers to a type, but is being used as a value here.
    3 | import { DrawTime, Scriptable, ShadowOptions } from './options';
    4 | 
  > 5 | type percentString = `${number}%`;
      |                         ^
    6 | export type LabelPosition = 'start' | 'center' | 'end' | percentString;
    7 | 
    8 | export type LabelTextAlign = 'left' | 'start' | 'center' | 'right' | 'end';
stockiNail commented 1 year ago

@Fordiboii thank you for your feedback. have a look to another issue (the same of this one): #563 The minim TS supported is 4.2

stockiNail commented 1 year ago

Apologize, I closed for my fault. Anyway have a look to above comment.