Fix correct drawing when elements are skipped and overlaid

chartjs / chartjs-plugin-datalabels

Chart.js plugin to display labels on data elements

https://chartjs-plugin-datalabels.netlify.app

MIT License

863 stars 460 forks source link

Fix correct drawing when elements are skipped and overlaid #323

Closed stockiNail closed 1 year ago

stockiNail commented 2 years ago

Fix #319

stockiNail commented 2 years ago

@simonbrunel I have applied the review you suggested

simonbrunel commented 1 year ago

Thanks @stockiNail! This PR has been manually merged (fed9762087d9224d12f87f4360dc7dec3abab5a1) since I wanted the test to use bigger labels. I'm not sure why it wasn't enabled for this PR but make sure to check the option to allow maintainers to push to your repository / branch.

stockiNail commented 1 year ago

Thanks @stockiNail! This PR has been manually merged (fed9762) since I wanted the test to use bigger labels. I'm not sure why it wasn't enabled for this PR but make sure to check the option to allow maintainers to push to your repository / branch.

It is weird. Usually I fetch al update a from the main before starting a PR. Anyway thank uou, I’ll pay more attention next time

simonbrunel commented 1 year ago

I'm thinking about the options "Allow edits by maintainers" when creating the PR (see step 7).