Fix default when the plugin is defined in chart configuration

chartjs / chartjs-plugin-datalabels

Chart.js plugin to display labels on data elements

https://chartjs-plugin-datalabels.netlify.app

MIT License

874 stars 473 forks source link

Fix default when the plugin is defined in chart configuration #325

Closed stockiNail closed 2 years ago

stockiNail commented 2 years ago

Fix #285

When the plugin is defined in chart configuration (and not globally registered) the offset and padding options were checked with a wrong default (0 instead of 4).

simonbrunel commented 2 years ago

The suggested change is fine, though I would expect defaults to be applied even while using the plugin locally.

stockiNail commented 2 years ago

I was thinking the same. Maybe an issue should be submitted to chartjs project

stockiNail commented 2 years ago

@simonbrunel I have seen that last merged PRs don't have the milestone. Will they be part of 2.1.0 or a bug fixing release 2.0.1?

simonbrunel commented 2 years ago

It will be 2.1.0 in which I would also like to include your other PR #271