search

chartjs / chartjs-plugin-datalabels

Chart.js plugin to display labels on data elements
https://chartjs-plugin-datalabels.netlify.app
MIT License
873 stars 473 forks source link

Fix compile errors when using multiple plugins #376

Closed stockiNail closed 1 year ago

stockiNail commented 1 year ago

Fix #374

simonbrunel commented 1 year ago

Awesome findings @stockiNail! Thank you for your perseverance figuring out what was the source issue. Your conclusions make sense and it's good that you discovered that rollup config change so it does not impact other types in the future. I agree that it should be fixed in the core library - thus closing this PR.

stockiNail commented 1 year ago

Thank you too @simonbrunel . Unfortunately my knowledge on TS is not so good and I needed some days to discover it. Maybe I could find it before...

simonbrunel commented 1 year ago

It was not an obvious issue and I'm sure you have learn a lot! Good job! 👍

stockiNail commented 1 year ago

you have learn a lot!

Definitely YES! Thank you again @simonbrunel