chartjs / chartjs-plugin-zoom

Zoom and pan plugin for Chart.js
MIT License
586 stars 326 forks source link

Fix "original" scale limits with nonlinear pan #774

Open joshkel opened 1 year ago

joshkel commented 1 year ago

Nonlinear scales failed to resolve "original" within panNumericalScale.

To fix this:

Add unit tests, both for this bug and for the preexisting but untested "original" feature.

I wanted JSDoc + TypeScript checks to help validate and document these changes, but that exposed apparent limitations of Chart.js core's type definitions. I'll open a separate PR for those.

trullock commented 3 days ago

This is merged into my fork at https://github.com/trullock/chartjs-plugin-zoom which is published on npm as @trullock/chartjs-plugin-zoom, as this fork seems abandoned