search

chartjs / chartjs-plugin-zoom

Zoom and pan plugin for Chart.js
MIT License
579 stars 322 forks source link

refactor: VuePress to VitePress #809

Open bavoco opened 4 months ago

bavoco commented 4 months ago

This reduces the number of dev dependencies by about 700.

Towards #812

NotTsunami commented 3 months ago

By nature, the move from VuePress -> VitePress should also allow us to drop the babel dependencies too, right? A very brief peek at the source suggests it is not used outside of VuePress.

NotTsunami commented 3 months ago

I tested it on your branch and npm run docs passes with the babel dependencies removed. With @babel/core, @babel/preset-env, and babel-loader removed, another 155 packages are removed. npm run test passes with 76/76 tests while npm run lint and npm run build complete without error.

NotTsunami commented 3 months ago

You should be able to remove ng-hammerjs as well, since it was only used in VuePress: https://github.com/chartjs/chartjs-plugin-zoom/blob/bfd207d9108cbcd612b8f4c2b0221ef8e7ed373b/docs/.vuepress/config.js#L89-L90

bavoco commented 3 months ago

Great! If #808 gets merged there won't be two versions of Rollup and related plugins further reducing the count.