search

chartmogul / chartmogul-php

ChartMogul API PHP Client
MIT License
18 stars 18 forks source link

Default backoff of 20 requests leads to long delay in case of error #132

Open beberlei opened 1 day ago

beberlei commented 1 day ago

I triggered a 500 error on the ChartMogul backend for some reason, so a call would always regenerate that error, and using the default backoff of 20 this felt like an endless loop, the script was hanging a long time. I believe reducing this to 3 or 5 by default would provide enough value but also end scripts earlier that run into errors on every call.

swember commented 1 day ago

Hello @beberlei, thanks a lot for the report. I believe 500 is not a normal situation which shouldn't be happening. Could you please provide which call caused that so we could investigate it further? Related the change of the number of retries we will consider that and prepare an update in the next release.

beberlei commented 23 hours ago

The problem is a faulty API call on my end, see the "custom" declaration not according to docs.

I sent this to my onboarding rep aswell as an email just now

Bildschirmfoto 2024-12-04 um 15 06 00

The backend error for this is an empty string.

swember commented 22 hours ago

Thank you @beberlei, we will take a look at the issue with the API and the library.