chartmuseum / charts

ChartMuseum Project Helm Charts
https://artifacthub.io/packages/search?repo=chartmuseum
54 stars 57 forks source link

chore: support Prefix type in ingress path. #35

Closed b0nete closed 2 years ago

b0nete commented 2 years ago

Use pathType as Prefix to work with Application Load Balancer.

closes https://github.com/chartmuseum/charts/issues/36

nerdeveloper commented 2 years ago

Hello @b0nete if you are busy, I can pick it up from where you stopped and start working on it. I will be glad to do it. thank you

nerdeveloper commented 2 years ago

I am going to take over this PR and submit it for merging this week

fede-r1c0 commented 2 years ago

@nerdeveloper can you merge your PR https://github.com/chartmuseum/charts/pull/42 in this branch?

fede-r1c0 commented 2 years ago

thanks for the PR! Just needs one small change

Also, can you bump the chart version to 3.7.0?

@cbuto chart version was upgraded to 3.7.0

nerdeveloper commented 2 years ago

unfortunately, I am not sure I can, as I dont have access to this particular branch

fede-r1c0 commented 2 years ago

unfortunately, I am sure I can, as I dont have access to this particular branch

sure, @b0nete or @cbuto can you create this PR?

https://github.com/b0nete/charts/compare/b0nete:patch-1...nerdeveloper:patch-1?expand=1

cbuto commented 2 years ago

@fede-r1c0 will @b0nete be handling this PR and working on it? if not, lets close it and move the conversation to https://github.com/chartmuseum/charts/pull/42. It will be easier to work on if @b0nete is unavailable.

b0nete commented 2 years ago

Sorry @cbuto, i didn't have notifications enabled i and couldn't see it in time.

nerdeveloper commented 2 years ago

lgtm! I'm guessing the docs will be updated automatically, right? @cbuto

cbuto commented 2 years ago

good point, the docs are a manual process right now. @b0nete can you add pathType to the docs in the README? Once that is in place, let’s merge it!

fede-r1c0 commented 2 years ago

good point, the docs are a manual process right now. @b0nete can you add pathType to the docs in the README? Once that is in place, let’s merge it!

@cbuto can you check the docs changes?

cbuto commented 2 years ago

@fede-r1c0 that looks awesome! thanks for taking the time to update those.