Closed b0nete closed 2 years ago
Hello @b0nete if you are busy, I can pick it up from where you stopped and start working on it. I will be glad to do it. thank you
I am going to take over this PR and submit it for merging this week
@nerdeveloper can you merge your PR https://github.com/chartmuseum/charts/pull/42 in this branch?
thanks for the PR! Just needs one small change
Also, can you bump the chart version to
3.7.0
?
@cbuto chart version was upgraded to 3.7.0
unfortunately, I am not sure I can, as I dont have access to this particular branch
unfortunately, I am sure I can, as I dont have access to this particular branch
sure, @b0nete or @cbuto can you create this PR?
https://github.com/b0nete/charts/compare/b0nete:patch-1...nerdeveloper:patch-1?expand=1
@fede-r1c0 will @b0nete be handling this PR and working on it? if not, lets close it and move the conversation to https://github.com/chartmuseum/charts/pull/42. It will be easier to work on if @b0nete is unavailable.
Sorry @cbuto, i didn't have notifications enabled i and couldn't see it in time.
lgtm! I'm guessing the docs will be updated automatically, right? @cbuto
good point, the docs are a manual process right now. @b0nete can you add pathType
to the docs in the README? Once that is in place, let’s merge it!
good point, the docs are a manual process right now. @b0nete can you add
pathType
to the docs in the README? Once that is in place, let’s merge it!
@cbuto can you check the docs changes?
@fede-r1c0 that looks awesome! thanks for taking the time to update those.
Use pathType as Prefix to work with Application Load Balancer.
closes https://github.com/chartmuseum/charts/issues/36