Open jonyrock opened 3 years ago
I believe that options should be first in the constructor here
abstract class ChartwerkPod<T extends TimeSerie, O extends Options> { // ... constructor( // maybe it's not the best idea _d3: typeof d3, protected readonly el: HTMLElement, protected readonly series: T[] = [], _options: O ) {
@rozetko please say what do you think
Not sure, because a pod can't render anything without el and series but can without options. I'd just make it optional (don't now why it's not)
el
series
options
I believe that options should be first in the constructor here