search

charwking / movie-club

A web app for running a work movie club
MIT License
3 stars 5 forks source link

Fix movie ordering #125

Closed squarejaw closed 9 years ago

squarejaw commented 9 years ago

There are currently two problems with movie ordering. The first occurs in myMovies.controller.js. The code is attempting to reorder the movies, but unfortunately the .forEach() in the lodash chain does not get called because it is deferred until .value() is called. This is actually the intended behavior!

I've copy-pasted the same code into hostMeeting.controller.js to reorder the user's movies after their first movie is selected.

I also fixed a typo that's been bugging me. :smile:

ttonyan10 commented 9 years ago

Thank you for fixing that typo!!!

And your profile pic is AWESOME. Seurat, Sunday Afternoon?

squarejaw commented 9 years ago

Yep, I recently saw it in person in Chicago; pretty awesome to see up close.

charwking commented 9 years ago

Nice. Thanks for the background on what the problem was too -- super helpful!