search

charwking / movie-club

A web app for running a work movie club
MIT License
3 stars 5 forks source link

Small update since there is a bower.json. #126

Closed AsmodeusXI closed 9 years ago

AsmodeusXI commented 9 years ago

I'm guessing this should be part of it? I could be wrong, but figured I'd add this (also wanted to test my setup, so here we are).

charwking commented 9 years ago

Bower is mentioned in the package.json, so it should be getting installed as part of the npm install command. Were you seeing issues?

If bower is only installed in the local node_modules directory, and not globally, I know that you won't be able to run a bower command without referencing the full path, e.g. node_modules/bower/bin/bower install. My attempt to take care of this was to have the npm install also do a bower install.

If that's not sufficient, then this change is spot on.

AsmodeusXI commented 9 years ago

You know, I think I just made an assumption based on the WWT environment about needing to pair a bower install with an npm install whenever you had a repo with both. Yay for learning experiences! More importantly, now I know how to contribute! Excellent.

charwking commented 9 years ago

Awesome! I'm looking forward to clicking the merge button on a PR from you!