charwking / movie-club

A web app for running a work movie club
MIT License
3 stars 5 forks source link

Unit tests #128

Closed BuffCoder closed 9 years ago

BuffCoder commented 9 years ago

Created unit tests for the following services:

charwking commented 9 years ago

Nice work @BrandonCKrueger! You're definitely going above and beyond by adding tests for code you didn't even write! These tests look like a good start to providing appropriate test coverage.

A couple notes for the future:

BuffCoder commented 9 years ago

Setting up $firebaseObjects and $firebaseArrays was a pain.

I did find this, fingular but didn't want to pull in any dependencies since you had mentioned dropping firebase and creating your own API. If you want to stick with firebase fingular might be worth looking at.