charwking / movie-club

A web app for running a work movie club
MIT License
3 stars 5 forks source link

Fix bug with whitelisted templates; Add tests #136

Closed charwking closed 9 years ago

charwking commented 9 years ago

This fixes a minor bug that would have prevented templates from being loaded from the domain where the movie-club website was running. This doesn't affect us now, since all the templates are preemptively cached, but doesn't hurt to fix.

It also gives me an excuse to add tests around the angular.config blocks. Testing config blocks takes a unique approach that required some research (read: googling). I also got a chance to use jasmine's .calls.mostRecent() method for the first time in a totally worthwhile situation.

The run blocks still need tests, but I'll leave that for another day (or another person).