search

charybdis-ircd / charybdis

Scalable IRCv3.2 server for large, community-oriented networks
GNU General Public License v2.0
231 stars 102 forks source link

3.5: Invalid command 'SJOIN' with only 3 arguments (expecting 4) #237

Open ShadowNinja opened 7 years ago

ShadowNinja commented 7 years ago

I've noticed this issue with Charybdis 3.5 (commit db05a36). I'll intermittently get netsplits with this error: [foo.net] *** Notice -- Dropping server bar.net due to (invalid) command 'SJOIN' with only 3 arguments (expecting 4). It happened a few days ago, and the last time before that was probably a month ago. All servers are running the same version of Charybdis. When the servers relink the same thing sometimes happens during netjoin, but sometimes they link fine.

kaniini commented 7 years ago

that's the tip of the iceberg really. when implementing MsgBuf support in charybdis 4, i found a lot of nasty stuff like this.

freenode is literally 1 security audit of ircd-seven away from having a really bad day.

kaniini commented 7 years ago

most likely your SJOIN is related to a +P channel that is empty. in some cases, the trailing : goes missing.

ShadowNinja commented 7 years ago

I did have an empty +P channel.