modules/m_sasl: Also check if the server the SASL agent is on has split from the network, to properly advertise the loss of the "sasl" cap for clients that support cap-notify. (Charybdis 4.1.x master)

charybdis-ircd / charybdis

Scalable IRCv3.2 server for large, community-oriented networks

GNU General Public License v2.0

231 stars 102 forks source link

modules/m_sasl: Also check if the server the SASL agent is on has split from the network, to properly advertise the loss of the "sasl" cap for clients that support cap-notify. (Charybdis 4.1.x master) #250

Closed MrBenC closed 6 years ago

MrBenC commented 7 years ago

Previously, it would only check if the SASL agent has quit, which normally only occurs if the SASL agent is unloaded. In Atheme and ChatServices, if services are restarted, the services server splits from the network. This means removal of the "sasl" cap never gets advertised to clients that support cap-notify, despite the loss of the capability.

This pull request updates Charybdis 4.1.x (master).

nomis commented 6 years ago

Fixed by 15b05f95f0aeed6fe840cf59a69bce2051d9e2ee