charybdis-ircd / charybdis

Scalable IRCv3.2 server for large, community-oriented networks
GNU General Public License v2.0
231 stars 102 forks source link

Configured m_webirc IP gets checked against blacklist while the actual client IP is ignored #255

Open Mikaela opened 6 years ago

Mikaela commented 6 years ago

Connecting to webchat (which is configured with m_webirc) over Tor doesn't result to any errors as it appears that the webchat IP is checked against the blacklists.

*** Checking your IP against DNS blacklists
*** IP not found in DNS blacklists
CGI:IRC host/IP set to 199.249.223.62 199.249.223.62
% host 62.223.249.199.6697.<our_IP>.ip-port.exitlist.torproject.org
62.223.249.199.6697.<our_IP>.ip-port.exitlist.torproject.org has address 127.0.0.2
Mikaela commented 6 years ago

Would this also happen to affect OPM?

I am curious about it as we have been having one persistent spammer that connects from many places (through webchat) which isn't Tor.

I would also be curious in what are the several issues that OPM causes, but this might not be the place for that.

nomis commented 6 years ago

Yes it will affect OPM too. The way m_webirc is currently implemented makes it hard to do this properly.

dwfreed commented 6 years ago

Don't start the checks until after NICK or USER is given. WEBIRC should always be given first anyway.

kaniini commented 6 years ago

not really possible due to the way authd is hooked in