Catastrophic compile fail in commio.c (librb) in (I believe) master

[janicez]

gmake[5]: Entering directory '/home/ellenor/src/charybdis/librb/src'
  CC       unix.lo                                                                                                    
  CC       win32.lo                                                                                                   
  CC       commio.lo                                                                                                  
  CC       balloc.lo                                                                                                  
In file included from commio.c:27:                                                                                    
commio.c: In function 'rb_settimeout':                                                                                
../include/rb_lib.h:161:52: warning: statement with no effect [-Wunused-value]                                        
 #define lrb_assert(expr) (assert(slrb_assert(expr)), 0)                                                              
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~                                                              
commio.c:276:2: note: in expansion of macro 'lrb_assert'                                                              
  lrb_assert(IsFDOpen(F));                                                                                            
  ^~~~~~~~~~                                                                                                          
commio.c: In function 'rb_accept_tcp':                                                                                
../include/rb_lib.h:161:52: warning: statement with no effect [-Wunused-value]                                        
 #define lrb_assert(expr) (assert(slrb_assert(expr)), 0)                                                              
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~                                                              
commio.c:584:2: note: in expansion of macro 'lrb_assert'                                                              
  lrb_assert(callback);                                                                                               
  ^~~~~~~~~~                                                                                                          
commio.c: In function 'rb_connect_tcp':                                                                               
../include/rb_lib.h:161:52: warning: statement with no effect [-Wunused-value]                                        
 #define lrb_assert(expr) (assert(slrb_assert(expr)), 0)                                                              
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~                                                              
commio.c:615:2: note: in expansion of macro 'lrb_assert'
  lrb_assert(callback);
  ^~~~~~~~~~                                               
commio.c: In function 'rb_open':
../include/rb_lib.h:161:52: warning: statement with no effect [-Wunused-value]
 #define lrb_assert(expr) (assert(slrb_assert(expr)), 0)   
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~   
commio.c:1102:2: note: in expansion of macro 'lrb_assert'
  lrb_assert(fd >= 0);
  ^~~~~~~~~~                                               
../include/rb_lib.h:161:52: warning: statement with no effect [-Wunused-value]
 #define lrb_assert(expr) (assert(slrb_assert(expr)), 0)   
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~   
commio.c:1106:2: note: in expansion of macro 'lrb_assert'
  lrb_assert(!IsFDOpen(F));
  ^~~~~~~~~~                                               
commio.c: In function 'rb_close':
../include/rb_lib.h:161:52: warning: statement with no effect [-Wunused-value]
 #define lrb_assert(expr) (assert(slrb_assert(expr)), 0)   
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~   
commio.c:1139:2: note: in expansion of macro 'lrb_assert'
  lrb_assert(IsFDOpen(F));
  ^~~~~~~~~~                                               
../include/rb_lib.h:161:52: warning: statement with no effect [-Wunused-value]
 #define lrb_assert(expr) (assert(slrb_assert(expr)), 0)   
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~   
commio.c:1141:2: note: in expansion of macro 'lrb_assert'
  lrb_assert(!(type & RB_FD_FILE));
  ^~~~~~~~~~                                               
../include/rb_lib.h:161:52: warning: statement with no effect [-Wunused-value]
 #define lrb_assert(expr) (assert(slrb_assert(expr)), 0)   
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~   

[aaronmdjones]

Those are warnings, not failures.

[janicez]

There was an error though... hold on

    lrb_assert(delem->node.parent == NULL);
    ^~~~~~~~~~
../include/rb_lib.h:161:52: warning: statement with no effect [-Wunused-value]
 #define lrb_assert(expr) (assert(slrb_assert(expr)), 0)
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
radixtree.c:1038:4: note: in expansion of macro 'lrb_assert'
    lrb_assert(next->leaf.parent == delem);
    ^~~~~~~~~~
../include/rb_lib.h:161:52: warning: statement with no effect [-Wunused-value]
 #define lrb_assert(expr) (assert(slrb_assert(expr)), 0)
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
radixtree.c:1039:4: note: in expansion of macro 'lrb_assert'
    lrb_assert(next->leaf.parent_val == val);
    ^~~~~~~~~~
../include/rb_lib.h:161:52: warning: statement with no effect [-Wunused-value]
 #define lrb_assert(expr) (assert(slrb_assert(expr)), 0)
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
radixtree.c:1043:4: note: in expansion of macro 'lrb_assert'
    lrb_assert(next->node.parent == delem);
    ^~~~~~~~~~
../include/rb_lib.h:161:52: warning: statement with no effect [-Wunused-value]
 #define lrb_assert(expr) (assert(slrb_assert(expr)), 0)
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
radixtree.c:1044:4: note: in expansion of macro 'lrb_assert'
    lrb_assert(next->node.parent_val == val);
    ^~~~~~~~~~
../include/rb_lib.h:161:52: warning: statement with no effect [-Wunused-value]
 #define lrb_assert(expr) (assert(slrb_assert(expr)), 0)
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
radixtree.c:1045:4: note: in expansion of macro 'lrb_assert'
    lrb_assert(next->node.nibnum > delem->node.nibnum);
    ^~~~~~~~~~
radixtree.c: In function 'rb_radixtree_stats':
../include/rb_lib.h:161:52: warning: statement with no effect [-Wunused-value]
 #define lrb_assert(expr) (assert(slrb_assert(expr)), 0)
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
radixtree.c:1074:2: note: in expansion of macro 'lrb_assert'
  lrb_assert(dict != NULL);
  ^~~~~~~~~~
version.c:31:42: error: 'DATECODE' undeclared here (not in a function)
 const unsigned long int librb_datecode = DATECODE;
                                          ^~~~~~~~
gmake[5]: *** [Makefile:817: version.lo] Error 1
gmake[5]: *** Waiting for unfinished jobs....
gmake[5]: Leaving directory '/home/ellenor/src/charybdis/librb/src'
gmake[4]: *** [Makefile:400: all] Error 2
gmake[4]: Leaving directory '/home/ellenor/src/charybdis/librb/src'
gmake[3]: *** [Makefile:472: all-recursive] Error 1
gmake[3]: Leaving directory '/home/ellenor/src/charybdis/librb'
gmake[2]: *** [Makefile:381: all] Error 2
gmake[2]: Leaving directory '/home/ellenor/src/charybdis/librb'
gmake[1]: *** [Makefile:473: all-recursive] Error 1
gmake[1]: Leaving directory '/home/ellenor/src/charybdis'
gmake: *** [Makefile:405: all] Error 2