search

charybdis-ircd / charybdis

Scalable IRCv3.2 server for large, community-oriented networks
GNU General Public License v2.0
231 stars 102 forks source link

m_info: access bools as the correct type #307

Open edk0 opened 4 years ago

aaronmdjones commented 4 years ago

This will not work; most of the booleans in the codebase referred to by m_info are actually ints, for example all of the stuff in ConfigFileEntry.

edk0 commented 4 years ago

We should make everything ints then. As it is, in increasing order of practical severity, it has undefined behaviour, could theoretically report wrong answers, and sets off asan.