charybdis-ircd / charybdis

Scalable IRCv3.2 server for large, community-oriented networks
GNU General Public License v2.0
231 stars 102 forks source link

Fix invite-notify and move it to an extension #319

Closed edk0 closed 4 years ago

edk0 commented 4 years ago

My motivation for moving out invite-notify is primarily that I want the freedom to not load it, which doesn't seem ideal from a maintenance perspective, but I have tried to test it.

The reason for the rather ugly two-stage solution is that invites can be rejected at the target end, and notifying half the network about an invite that doesn't actually happen seems wrong. This approach has the disadvantage that, if the inviter or invitee quits at the wrong moment, the notification can get lost. I think that's less bad.