charybdis-ircd / charybdis

Scalable IRCv3.2 server for large, community-oriented networks
GNU General Public License v2.0
230 stars 102 forks source link

consider sending set by/at on BMASK burst #337

Open jesopo opened 4 years ago

jesopo commented 4 years ago

My understanding is that not sending these was a space saving mechanism but we have more bandwidth now and it does actually lead to two real-world issues that I've observed frequently:

I've considered how one would best change the BMASK format to include these params and there's only two solutions that come to mind:

I took an average of hostmask lengths in #freenode (1549 users) and found 40.2 bytes, so both of these solutions would add, on average, 52.2 bytes per mask (10 for ts, 52.2 for setter, 2 for delimiters)

you could, somehow, do deduplication of setter hostmasks; i am not sure of a good way to do this