charybdis-ircd / charybdis

Scalable IRCv3.2 server for large, community-oriented networks
GNU General Public License v2.0
231 stars 102 forks source link

make `+rb $~a` prioritise ERR_NEEDREGGEDNICK #361

Open jesopo opened 3 years ago

jesopo commented 3 years ago

rationale is that prioritising the version that gives the most information about the reason for not being able to join is a good idea, though this makes less sense for +rb nick!*@* when your nick is nick, but you'd still have to address both reasons for not being able to join in any case.

one could argue this should instead be solved by -b $~a but i can imagine people unintentionally having both set or wanting the fallback or whatever, and prioritising +r might lead to fewer confused users.

I assume this is as simple as moving https://github.com/charybdis-ircd/charybdis/blob/9dd128b4da6e54ca9f97cfcd48e345a57790ffbe/ircd/channel.c#L736-L737 above https://github.com/charybdis-ircd/charybdis/blob/9dd128b4da6e54ca9f97cfcd48e345a57790ffbe/ircd/channel.c#L694