search

chase-moskal / xiome

open-source cloud-powered web components
https://xiome.io/
MIT License
10 stars 13 forks source link

Correction to chat height - #119 #121

Closed LewBlu closed 2 years ago

LewBlu commented 2 years ago

Issue originally named as a bug with the height which i have now corrected. Specified that height for the property instead of it trying to read from itself, then added a fall back where the property is used to match the original value.

Noticed issue now says chat height is too tall. Currently set to 20em, would this need decreasing?

chase-moskal commented 2 years ago

@LewBlu awesome, that fixes it

i added one tiny tweak commit, that actually removes one of the 20em rules, which turns out to be unnecessary (only one was needed) -- see that change here: https://github.com/chase-moskal/xiome/pull/121/commits/d6facfa53fd1a47717e12d1f13cc4a711e3b7a81

chase-moskal commented 2 years ago

:tada: merged to master