notes-model and xiome-notes functionality stub

chase-moskal / xiome

open-source cloud-powered web components

https://xiome.io/

MIT License

10 stars 13 forks source link

notes-model and xiome-notes functionality stub #85

Closed PaulAroo closed 3 years ago

PaulAroo commented 3 years ago

addressed issues on this ticket

chase-moskal commented 3 years ago

@PaulAroo

i found a bug that we need to fix

[x] removing last note on last page doesn't go to previous page
- i added 11 new notes, and refreshed
- i clicked next page
- i saw 1 notes on page 2, which is good
- but then, i marked the note old
- :x: the bug: the notes list said it was empty (it should switch back to the first page)

chase-moskal commented 3 years ago

@PaulAroo i've added a failing test to your branch notes-caching in a new commit b9399d06c65caf304a492558bf720aa9e6a57134

after you fix the bug in the notes cache, all tests should pass when you run npm test, and then you will know the bug is fixed

chase-moskal commented 3 years ago

i've added a new failing test, that shows the fix attempt is not sufficient

branch notesbug includes the two failing tests, without any implementation
branch notesfix1 includes the incorrect implementation attempt that fails the second test

@PaulAroo you should try again, continuing your work on a new branch based on either of those two branches -- when the work is complete, you can hard reset your notes-caching branch for this pull-request onto the new work branch