search

chase / awrit

A full graphical web browser for Kitty terminal with mouse and keyboard support
Other
503 stars 19 forks source link

Fetch sha1 dynamically, support macosx64 #28

Closed CLRN closed 10 months ago

CLRN commented 10 months ago

Hi, this is to cover https://github.com/chase/awrit/blob/e7ad5be6d2eee3c87f5f8aac254ceae08f2fe3e0/CMakeLists.txt#L20 and to fix build on macos 64 bit, unfortunately I can't verify if the build passes on other platforms.

chase commented 10 months ago

@CLRN thanks for the PR!

I noticed this uses jq to handle the JSON, and I'm not sure if I want to introduce another dependency to build awrit.

Since CMake 3.19, has supported querying JSON: https://cmake.org/cmake/help/latest/command/string.html#json

It might not be sufficient, but if you have time, I'd appreciate if you could make this PR use that instead.

CLRN commented 10 months ago

Hey, yeah, that was my concern as well, unfortunately CMake doesn't have any functionality for filtering JSON. But let me see how messy it would be without it.

CLRN commented 10 months ago

@chase done, please have a look, thanks.