'No missing ID's' when there are missing IDs - Githubissues

chasemc / IDBacApp

A MALDI Mass Spectrometry Bioinformatics Platform

https://chasemc.github.io/IDBac

Other

28 stars 7 forks source link

'No missing ID's' when there are missing IDs #125

Open chasemc opened 5 years ago

chasemc commented 5 years ago

When entering IDs for the Bruker conversion 'No missing ID's' is displayed no matter what after saving.

Relevant https://github.com/chasemc/IDBacApp/blob/665f449d52dd3c8a31315431e10789de06e8cc17/R/module_convertBruker.R#L170-L195

Also, update unit test: https://github.com/chasemc/IDBacApp/blob/6bed5abdee2b09b6e128ba623539b34d5e16e412/tests/testthat/test-findmissingsamplemapids.R