search

chaseoes / FirstJoinPlus

Customize all aspects of new players joining for the first time.
http://dev.bukkit.org/bukkit-plugins/firstjoinplus/
11 stars 16 forks source link

Add support for ItemMeta and a command to set items from current inventory. #17

Closed andrepl closed 10 years ago

andrepl commented 11 years ago

First let me say I know this might be problematic to pull as-is since it makes several changes, feel free to reject and just take whatever you might be interested in.

Firstly, it adds support for directly serializing and deserializing itemstacks from the give-items.items list, so that any items with any meta can be supported, it does so in a backwards compatible way so that the old colon-separated-string format will still work.

Secondly it drops all the custom written book code, as it becomes redundant when full item meta is supported. (though the interface may not be as nice as a text-editor, so this is controvercial)

Thirdly it adds a setitems command that populates the give-items.items list with the contents of the CommandSender's inventory.

chaseoes commented 10 years ago

I like the idea of a command however I would prefer the items be configurable via the configuration (in an easy manner) and do not want this plugin to turn into a fully featured kit plugin -- other kit plugins can be used in conjunction of FirstJoinPlus to provide a much better experience.

Additionally, I have let this sit for a while and version 2.0 has removed some of the kit functionality.