search

chaseruskin / legoHDL

An experimental package manager and development tool for Hardware Description Languages (HDL).
https://c-rus.github.io/legoHDL
MIT License
14 stars 2 forks source link

Transfer from os.system() to subprocess #17

Closed chaseruskin closed 3 years ago

chaseruskin commented 3 years ago

Subprocess is more versatile and provides better functionality compared to os.system().

Create an "execute" method to be wrap subprocess call.

chaseruskin commented 3 years ago

An issue arose related to: https://stackoverflow.com/questions/3022013/windows-cant-find-the-file-on-subprocess-call. PATH is not found unless shell=True for subprocesses, which is discouraged to enable. This was an issue encountered when editor = code. Reverted execution back to using os.system() due to stability and because there are few calls for the tool to execute (mainly opening windows in the configured text-editor).