search

chaserx / gems-cli

search rubygems on the command line; get formatted results for your gemfile
MIT License
8 stars 1 forks source link

[Fix #10] Relaxed dependent Gem versions in Gemspec. #11

Closed jdickey closed 8 years ago

jdickey commented 9 years ago

...while maintaining now-current dependency versions. A bit of future-proofing.

RSpec: 13 examples, 0 failures (as of Commit 123c2277) (No coverage or style-compliance checking yet.)

jdickey commented 9 years ago

Travis died because .travis.yml doesn't run bundle install before running rspec. The Travis documentation says that the non-deployment bundle install is only run

when we detect a Gemfile in the project's root directory, or if the Gemfile specified via the build matrix exists.

The build log indicates that this bundle install was not run. Investigating why; any ideas?

That ought to be an issue in itself, separate from #10. :unamused:

chaserx commented 9 years ago

nice! should be able to update .travis.yml to customize the build so that bundle install happens.

jdickey commented 9 years ago

You'd think it'd be straightforward, reading the doc that I quoted, wouldn't you? I've never used Travis (we're happy on CodeShip), but the doc makes it sound so easy. Then again, in theory, there is no difference between theory and practice... any ideas?

chaserx commented 9 years ago

Hmm. Not at the moment. I'm not great with Travis either... I'll tackle this later today.

jdickey commented 9 years ago

Thanks. It's 01.30 here and I'm just winding up my "day job" for the "day". I'll look at this again in ~10 hours and see if sleep brings any bright ideas. There's a couple more things I wanted to suggest for the app/Gem; this (Issue #10) was pretty much a smoke test.

Good hunting.

chaserx commented 9 years ago

So looks like two options in the .travis.yml to fix this problem: 1) add a install directive to override the default install with the following install: bundle install OR 2) add bundler_args directive to override the bundle arguments with an empty string the following: bundler_args:

chaserx commented 9 years ago

See #12 to that updates the travis.yml

chaserx commented 9 years ago

It appears to change the build command and looks like it might fix your problem. I can add this into master and you can rebase or you can merge this branch into your branch and see if it builds tests pass.

chaserx commented 9 years ago

I merged the updated travis.yml file. You'll want to rebase or merge master to resolve conflicts as needed.

chaserx commented 8 years ago

looks like the cloned repo and branch for this PR have been deleted. I couldn't figure out a way to cherry-pick or make a patch of this since I can't make a new remote. I've copied over the work in #22 and given attribution. thanks for the help.

jdickey commented 8 years ago

Sorry about that. I think I did some "cleanup" of repos that I didn't remember why I'd forked and this got tossed into the bin. Note to self: do not do repo changes at the end of the "day"! 😩