search

chatch / stellar-hd-wallet

🔐 Key derivation for Stellar (SEP-0005) 🚀
https://www.npmjs.com/package/stellar-hd-wallet
Apache License 2.0
84 stars 48 forks source link

Add validation #4

Closed johansten closed 6 years ago

johansten commented 6 years ago

Adds a function to validate mnemonics for user feedback

chatch commented 6 years ago

nice. would you mind adding a test case for this in here: https://github.com/chatch/stellar-hd-wallet/blob/master/test/stellar-hd-wallet.js too? you can run "npm test" to check it.

chatch commented 6 years ago

merged. thanks!

i'll write the tests for this .. and will release a new npm version soon.

chatch commented 6 years ago

published to npm v0.0.5

johansten commented 6 years ago

Awesome, I got side tracked with SBC.

I wish validation was more granular in detecting errors, but then we'd have to go down to the bip39 level. ¯\(ツ)/¯

chatch commented 6 years ago

no worries. do you mean more specific errors returned rather then just false?