search

chatch / stellarexplorer

Ledger Explorer for the Stellar Network 🚀
https://steexp.com
Apache License 2.0
457 stars 1.06k forks source link

apply linter with `npm run lint:fix` #547

Closed jp-ryuji closed 10 months ago

jp-ryuji commented 10 months ago

Made sure the server is up and running on npm run dev. No console error is shown on the start up (as I've seen here: https://github.com/chatch/stellarexplorer/pull/546 ). Quickly navigated some pages on http://publicnet.local:3000/ locally and they looked fine.

There are still some formatting issues that can't be fixed automatically as follows. I left them for now. So github actions can't be set up now.

$ npm run lint
: 
✖ 57 problems (6 errors, 51 warnings)
  0 errors and 1 warning potentially fixable with the `--fix` option.
chatch commented 10 months ago

@jp-ryuji i pushed a change to service-worker.js. checkout the comma in there. it's fine to disable this rule there and that clears up 5 of the errors

chatch commented 10 months ago

fixed remaining error too.

jp-ryuji commented 10 months ago

This PR was superseded by https://github.com/chatch/stellarexplorer/pull/549