Build wheels with py3.12 to reduce build time

chatnoir-eu / chatnoir-resiliparse

A robust web archive analytics toolkit

https://resiliparse.chatnoir.eu

Apache License 2.0

55 stars 9 forks source link

Build wheels with py3.12 to reduce build time #33

Closed cclauss closed 7 months ago

cclauss commented 7 months ago

This pull request contains all changes in #32 plus just one additional change: Build wheels using Py3.12 instead of Py3.10.

We try the shift to Python 3.12 because builds take a lot of CI time to build and:

CPython 3.11 is ~25% faster than Python 3.10 and
CPython 3.12 is ~5% faster than Python 3.11.

Will these CPython speed increases allow us to save CI build time, especially on macOS?

OS and Job Step	CPython 3.10	CPython 3.12	difference
Ubuntu Build FastWARC	3m 51s	3m 53s	~
Ubuntu Build Resiliparse	6m 52s	6m 59s	~
Windows Build FastWARC	6m 19s	4m 58s	Nice!
Windows Build Resiliparse	7m 15s	7m 2s	~
macOS Build FastWARC	14m 34s	10m 1s	Nice!
macOS Build Resiliparse	23m 3s	20m 2s	Nice!

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0a6d6e6) 90.62% compared to head (6003260) 81.69%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #33 +/- ## =========================================== - Coverage 90.62% 81.69% -8.93% =========================================== Files 19 19 Lines 3092 3092 =========================================== - Hits 2802 2526 -276 - Misses 290 566 +276 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cclauss commented 7 months ago

The codecov failure seems nonsensical to me. Any thoughts?