search

chatscope / chat-ui-kit-react

Build your own chat UI with React components in few minutes. Chat UI Kit from chatscope is an open source UI toolkit for developing web chat applications.
https://chatscope.io
MIT License
1.34k stars 116 forks source link

OnKeyDown event occurs twice when typing in Korean and then hitting enter #9

Closed HwangTaehyun closed 3 years ago

HwangTaehyun commented 3 years ago

Hi, thank you for intuitive and awesome chat-ui library.

I'm using it well, but there are some bugs like following situations.

OnKeyDown event occurs twice when typing in Korean and then hitting enter. So Last Korean Character printed one more time. Korean Input Bug

supersnager commented 3 years ago

@HwangTaehyun Thanks for PR. I will reproduce this bug before merging, and check if everything works for other edge cases as well.

HwangTaehyun commented 3 years ago

I checked again, and it works fine in Chrome on Windows, and it seems that this problem occurs in Chrome on Mac. Please note. Thank you!

supersnager commented 3 years ago

@HwangTaehyun Thanks!

kolt-suzuki commented 3 years ago

This issue is critical for Japanese users too. I hope it would be merged quickly.

supersnager commented 3 years ago

@kolt-suzuki I will take care of it this week.

supersnager commented 3 years ago

@HwangTaehyun @kolt-suzuki

The PR from @HwangTaehyun uses keypress event which is unfortunately deprecated (source: https://developer.mozilla.org/en-US/docs/Web/API/Document/keypress_event#Deprecated)

I don't want to keep deprecated features in the code. However, I have done some research and it looks like there is no other workaround for this chrome bug. So I have tested the PR and it's ok. I will merge it, but @HwangTaehyun please change the commit message as I mentioned in the PR comment.

bibek-magar commented 3 years ago

Waiting for ticket to merged....

supersnager commented 3 years ago

:tada: This issue has been resolved in version 1.5.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

supersnager commented 3 years ago

@HwangTaehyun Thank you for your contribution!

HwangTaehyun commented 3 years ago

@supersnager Thank you for your effort!