search

chaucoder / checker-plugin

Automatically exported from code.google.com/p/checker-plugin
0 stars 0 forks source link

checker results not appearing in problem view #1

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
This is what I did:
- running Eclipse 3.6 on Windows 7, Cygwin, running Java 1.6
- had an existing project in Eclipse
- installed the plugin from the update site, restarted
- downloaded the checkers.jar file, added to the project classpath, cleaned and 
rebuilt
- Ran the checkers nullness test
- Sensible output appeared in the console
- No problems were added to the problems view; checked the configuration of the 
Problems view - checker framework enabled - other kinds of problems are shown

What is the expected output? What do you see instead?
Expected to see errors/warnings from the Checker framework in the problems view

What version of the product are you using? On what operating system?
beta

Please provide any additional information below.

Original issue reported on code.google.com by c...@frontiernet.net on 20 Aug 2010 at 2:49

GoogleCodeExporter commented 8 years ago 
Hi, thanks for the bug report. First of all, can you tell me which version of 
the software you are using? You can find this from About Eclipse -> 
Installation Details.

Also, can you attach some output from the console? Parsing of error messages 
had some bugs several versions ago which have since been fixed, but it is 
possible we missed some cases.

Original comment by asumu.ta...@gmail.com on 21 Aug 2010 at 4:24

GoogleCodeExporter commented 8 years ago 
Version information:

I'm using version 0.0.15 of the Checker Framework Feature
Build id: 20100617-1415 of helios

Here is the console contents:

C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SExpr.java:67: warning: 
invalid type argument;

    static public class Printer implements Visitor<Void> {
                                                   ^
  found   : @Nullable Void

  required: @NonNull Object
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Solver_test.java:20: 
warning: incompatible types.

    private CommandResult status = null;
                                   ^
  found   : null

  required: @NonNull CommandResult
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Solver_test.java:181: 
warning: incompatible types.

        symTable.addSort(sortName,sortArity,null);
                                            ^
  found   : null

  required: @NonNull SExpr
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Solver_test.java:207: 
warning: incompatible types.

            return null;
                   ^
  found   : null

  required: @NonNull Sort
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Solver_test.java:213: 
warning: incompatible types.

            if (sexprs.size() == 0) return null;
                                           ^
  found   : null

  required: @NonNull Sort
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Solver_test.java:217: 
warning: incompatible types.

                return null; // FIXME - check the arguments anyway?
                       ^
  found   : null

  required: @NonNull Sort
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Solver_test.java:241: 
warning: incompatible types.

            return sort;
                   ^
  found   : @Nullable Sort

  required: @NonNull Sort
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Solver_test.java:247: 
warning: incompatible types.

            return null;
                   ^
  found   : null

  required: @NonNull Sort
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Solver_test.java:253: 
warning: incompatible types.

            return null;
                   ^
  found   : null

  required: @NonNull Sort
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Solver_test.java:259: 
warning: incompatible types.

            return null;
                   ^
  found   : null

  required: @NonNull Sort
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SymbolTable.java:23: 
warning: incompatible types.

        return sorts.get(name);
                        ^
  found   : @Nullable Sort

  required: @NonNull Sort
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SymbolTable.java:41: 
warning: incompatible types.

        if (arityMap == null) return null;
                                     ^
  found   : null

  required: @NonNull Sort
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SymbolTable.java:43: 
warning: incompatible types.

        return sort;
               ^
  found   : @Nullable Sort

  required: @NonNull Sort
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Solver_simplify.java:56: 
warning: incompatible types.

        process = null;
                  ^
  found   : null

  required: @NonNull Process
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Utils.java:66: warning: 
incompatible types.

        return null;
               ^
  found   : null

  required: @NonNull Sort
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Utils.java:141: warning: 
incompatible types.

        return null;
               ^
  found   : null

  required: @NonNull Object
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Utils.java:167: warning: 
incompatible types.

        return null;
               ^
  found   : null

  required: @NonNull CommandResult
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Utils.java:176: warning: 
incompatible types.

        if (!(o instanceof SExpr.Seq)) return null;// FIXME - error
                                              ^
  found   : null

  required: @NonNull CommandResult
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Utils.java:182: warning: 
incompatible types.

            symTable.addSort(name,arity,null);
                                        ^
  found   : null

  required: @NonNull SExpr
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Utils.java:207: warning: 
incompatible types.

        return null; // Successful
               ^
  found   : null

  required: @NonNull CommandResult
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SMT.java:11: warning: 
incompatible types.

    static public String logicPath = null;
                                     ^
  found   : null

  required: @NonNull String
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SMT.java:13: warning: 
incompatible types.

    static public String theoryPath = null;
                                      ^
  found   : null

  required: @NonNull String
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SMT.java:84: warning: 
incompatible types.

        Solver solver = startSolver(solvername, executable);
                                                ^
  found   : @Nullable String

  required: @NonNull String
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SMT.java:122: warning: 
incompatible types.

                return null;
                       ^
  found   : null

  required: @NonNull Solver
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SMT.java:127: warning: 
incompatible types.

            return null;
                   ^
  found   : null

  required: @NonNull Solver
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SMT.java:131: warning: 
incompatible types.

            return null;
                   ^
  found   : null

  required: @NonNull Solver
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SMT.java:135: warning: 
incompatible types.

            return null;
                   ^
  found   : null

  required: @NonNull Solver
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SMT.java:139: warning: 
incompatible types.

            return null;
                   ^
  found   : null

  required: @NonNull Solver
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SMT.java:143: warning: 
incompatible types.

            return null;
                   ^
  found   : null

  required: @NonNull Solver
29 warnings

C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SExpr.java:67: warning: 
invalid type argument;

    static public class Printer implements Visitor<Void> {
                                                   ^
  found   : @Nullable Void

  required: @NonNull Object
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Solver_test.java:20: 
warning: incompatible types.

    private CommandResult status = null;
                                   ^
  found   : null

  required: @NonNull CommandResult
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Solver_test.java:181: 
warning: incompatible types.

        symTable.addSort(sortName,sortArity,null);
                                            ^
  found   : null

  required: @NonNull SExpr
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Solver_test.java:207: 
warning: incompatible types.

            return null;
                   ^
  found   : null

  required: @NonNull Sort
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Solver_test.java:213: 
warning: incompatible types.

            if (sexprs.size() == 0) return null;
                                           ^
  found   : null

  required: @NonNull Sort
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Solver_test.java:217: 
warning: incompatible types.

                return null; // FIXME - check the arguments anyway?
                       ^
  found   : null

  required: @NonNull Sort
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Solver_test.java:241: 
warning: incompatible types.

            return sort;
                   ^
  found   : @Nullable Sort

  required: @NonNull Sort
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Solver_test.java:247: 
warning: incompatible types.

            return null;
                   ^
  found   : null

  required: @NonNull Sort
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Solver_test.java:253: 
warning: incompatible types.

            return null;
                   ^
  found   : null

  required: @NonNull Sort
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Solver_test.java:259: 
warning: incompatible types.

            return null;
                   ^
  found   : null

  required: @NonNull Sort
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SymbolTable.java:23: 
warning: incompatible types.

        return sorts.get(name);
                        ^
  found   : @Nullable Sort

  required: @NonNull Sort
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SymbolTable.java:41: 
warning: incompatible types.

        if (arityMap == null) return null;
                                     ^
  found   : null

  required: @NonNull Sort
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SymbolTable.java:43: 
warning: incompatible types.

        return sort;
               ^
  found   : @Nullable Sort

  required: @NonNull Sort
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Solver_simplify.java:56: 
warning: incompatible types.

        process = null;
                  ^
  found   : null

  required: @NonNull Process
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Utils.java:66: warning: 
incompatible types.

        return null;
               ^
  found   : null

  required: @NonNull Sort
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Utils.java:141: warning: 
incompatible types.

        return null;
               ^
  found   : null

  required: @NonNull Object
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Utils.java:167: warning: 
incompatible types.

        return null;
               ^
  found   : null

  required: @NonNull CommandResult
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Utils.java:176: warning: 
incompatible types.

        if (!(o instanceof SExpr.Seq)) return null;// FIXME - error
                                              ^
  found   : null

  required: @NonNull CommandResult
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Utils.java:182: warning: 
incompatible types.

            symTable.addSort(name,arity,null);
                                        ^
  found   : null

  required: @NonNull SExpr
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\Utils.java:207: warning: 
incompatible types.

        return null; // Successful
               ^
  found   : null

  required: @NonNull CommandResult
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SMT.java:11: warning: 
incompatible types.

    static public String logicPath = null;
                                     ^
  found   : null

  required: @NonNull String
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SMT.java:13: warning: 
incompatible types.

    static public String theoryPath = null;
                                      ^
  found   : null

  required: @NonNull String
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SMT.java:84: warning: 
incompatible types.

        Solver solver = startSolver(solvername, executable);
                                                ^
  found   : @Nullable String

  required: @NonNull String
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SMT.java:122: warning: 
incompatible types.

                return null;
                       ^
  found   : null

  required: @NonNull Solver
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SMT.java:127: warning: 
incompatible types.

            return null;
                   ^
  found   : null

  required: @NonNull Solver
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SMT.java:131: warning: 
incompatible types.

            return null;
                   ^
  found   : null

  required: @NonNull Solver
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SMT.java:135: warning: 
incompatible types.

            return null;
                   ^
  found   : null

  required: @NonNull Solver
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SMT.java:139: warning: 
incompatible types.

            return null;
                   ^
  found   : null

  required: @NonNull Solver
C:\cygwin\home\dcok\eclipseProjects\SMT\src\org\smtlib\SMT.java:143: warning: 
incompatible types.

            return null;
                   ^
  found   : null

  required: @NonNull Solver
29 warnings

Original comment by c...@frontiernet.net on 21 Aug 2010 at 12:36

GoogleCodeExporter commented 8 years ago 
I was able to reproduce this problem and it appeared to be a Windows specific 
issue due to line termination characters. I have a fix in the repository, so I 
will make a new release on the update site soon that should fix this.

Original comment by asumu.ta...@gmail.com on 25 Aug 2010 at 6:23

GoogleCodeExporter commented 8 years ago

Original comment by asumu.ta...@gmail.com on 27 Aug 2010 at 2:05

GoogleCodeExporter commented 8 years ago 
Updated to version 1.0.1

Now I get nothing in the Console or as Problem markers or in the Problems View.
In fact it is not clear that the checker is running when I choose, say, the 
Nullness checker from the context window.

Original comment by c...@frontiernet.net on 28 Aug 2010 at 1:03

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
I have the same version running on Windows and cannot reproduce this problem. 
Can you give me more information to reproduce this? This sounds like the plugin 
may be type-checking successfully. Are you using annotations in comments? If 
so, do you have the nullness checker selected in the preferences? (I will add 
this to the documentation: in the latest version, checkers must be selected in 
the preferences for their annotation imports to be active. This change was made 
to avoid annotation conflicts)

If it is not an implicit import problem, do you see any plugin instantiation 
problems in the Eclipse error log? Do other UI elements of the plugin work?

Original comment by asumu.ta...@gmail.com on 28 Aug 2010 at 1:40

GoogleCodeExporter commented 8 years ago 
Asumu:  I see this problem in the Error Console

java.lang.NullPointerException
at 
org.eclipse.core.internal.runtime.Activator.getURLConverter(Activator.java:313)
at org.eclipse.core.runtime.FileLocator.toFileURL(FileLocator.java:205)
at 
checkers.eclipse.javac.CommandlineJavacRunner.javacJARlocation(CommandlineJavacR
unner.java:216)
at 
checkers.eclipse.javac.CommandlineJavacRunner.options(CommandlineJavacRunner.jav
a:89)
at 
checkers.eclipse.javac.CommandlineJavacRunner.run(CommandlineJavacRunner.java:57
)
at checkers.eclipse.actions.CheckerWorker.runChecker(CheckerWorker.java:112)
at checkers.eclipse.actions.CheckerWorker.work(CheckerWorker.java:96)
at checkers.eclipse.actions.CheckerWorker.run(CheckerWorker.java:77)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)

Essentially, the plug-in is behaving as if no checking is happening - whether I 
use annotations-in-comments or not.  I do have the Nullness checker selected in 
the Preferences; I have an explicit, obvious nullness violation to catch; I've 
tried using the 'Run selected checkers' and tried the specific checker from the 
sub-menu.

Original comment by c...@frontiernet.net on 28 Aug 2010 at 8:31

GoogleCodeExporter commented 8 years ago 
Thanks, that has helped me reproduce the problem. Do you get this problem when 
you don't have implicit imports enabled? (regardless of whether you annotations 
in comments or not) Using implicit imports causes the plugin to use a different 
.jar to do the type-checking. Unfortunately, this .jar wasn't on the binary 
build path of the plugin so it wasn't getting included in builds (which is why 
I couldn't reproduce the program on my development builds).

I will push out a fix as 1.0.2 and also include the naming fix that you 
suggested.

Original comment by asumu.ta...@gmail.com on 29 Aug 2010 at 5:35

GoogleCodeExporter commented 8 years ago 
1.0.2 is in the update site and should fix this issue.

Original comment by asumu.ta...@gmail.com on 29 Aug 2010 at 5:42

GoogleCodeExporter commented 8 years ago 
Fix verified in my environment - version 1.0.2 (with implicit imports enabled)

Original comment by c...@frontiernet.net on 31 Aug 2010 at 12:29