search

chaudum / rgain3

A Python 3 compatible fork of rgain -- ReplayGain tools and Python library
GNU General Public License v2.0
51 stars 10 forks source link

treat OPUS as OGG/don't use extension to determine file type #13

Open 2019-05-10 opened 4 years ago

2019-05-10 commented 4 years ago

$ replaygain -d test.opus test.opus: not supported, ignoring it Checking for Replay Gain information ... Nothing to do.

rename file to test.ogg and it works:

$ replaygain -d test.ogg Checking for Replay Gain information ... test.ogg:none Calculating Replay Gain information ... test.ogg:4.49 dB Album gain: 4.49 dB Done

relying on file extensions has never been a reliable way to determine a file type.

chaudum commented 4 years ago

Hi @2019-05-10 Thanks for reporting :)

relying on file extensions has never been a reliable way to determine a file type.

Since I took over the existing code base and ported it to Python 3, I only start improving it now. Your suggestion to determine the file type correctly seems to be a valid request.

chaudum commented 4 years ago

@2019-05-10 FYI, I just merged #22 into master

calestyo commented 2 years ago

Shouldn't this work already in 1.1.1? Cause here it doesn't:

$ replaygain *
a.opus: not supported, ignoring it
b.opus: not supported, ignoring it
Checking for Replay Gain information ...
Nothing to do.