search

chaudum / rgain3

A Python 3 compatible fork of rgain -- ReplayGain tools and Python library
GNU General Public License v2.0
51 stars 10 forks source link

collectiongain fails to recognize albums for m4a (aac) files #27

Open jtbr opened 4 years ago

jtbr commented 4 years ago

When I run collectiongain on an album containing (at least some) AAC files, the individual tracks are always marked as single tracks rather than as an album:

~/Music/Fiona Apple/Tidal $ collectiongain --regain -d .
Collecting files ...
  [1] 08 The Child Is Gone.m4a |<single track>
  [2] 04 Criminal.m4a |<single track>
  [3] 09 Pale September.m4a |<single track>
  [4] 03 Shadowboxer.m4a |<single track>
  [5] 05 Slow Like Honey.m4a |<single track>
  [6] 02 Sullen Girl.m4a |<single track>
  [7] 10 Carrion.m4a |<single track>
  [8] 06 The First Taste.m4a |<single track>
  [9] 01 Sleep To Dream.m4a |<single track>
  [10] 07 Never Is A Promise.m4a |<single track>

Even though both the artist, albumartist, and album are set to be the same for all these files. At first, albumartist was not set, and I thought that could be the problem, but I get the same result when it is set to equal artist. These files do not have MusicMatch tags.

jtbr commented 4 years ago

I noticed PR #25 which seemed like it might solve the issue. Indeed, after manually patching my install, collectiongain seems to be working correctly for these mp4 files.

chaudum commented 4 years ago

I'm happy to hear that #25 works with your files. m4a support should go into the next release.