Open nathanpovo opened 8 months ago
Thanks for this! I have zero experience with Docker so I'm going to trust you.
Actually, could you modify the PR to add the instructions themselves to the README (make a new section just for Docker)? Otherwise what you wrote in the PR description can be hard to find.
add the instructions themselves to the README
Will do
@chauduyphanvu would it be possible for the default value of the default_save_location
to be changed from the current value of "DEFAULT_REDDIT_SAVE_LOCATION"
to ""
.
It would make it easier for any users of the docker container since the current default error throws an error if it is left as it is.
Is there any benefit of using the current default value? The script asks you what location you want to use anyway if you use ""
as the default value so I did not get the point. Admittedly, I never used the script directly so I am not sure if it would offer any benefits in that situation.
Creates a docker file that can be used to run the script without the need to have
ruby
installed locally.How to use
settings.json
to set the path of the downloadedmd
filesChange the setting
default_save_location
from the default value of"DEFAULT_REDDIT_SAVE_LOCATION"
to""
.For fellow
powershell
users: this has to be changed slightly to:Output
With the above instructions, this is the output I get when running the demo: