search

chauduyphanvu / reddit-markdown

MIT License
34 stars 6 forks source link

Unable to get the script to recognize DEFAULT_REDDIT_SAVE_LOCATION #20

Open MonsterSe7en opened 2 weeks ago

MonsterSe7en commented 2 weeks ago

Excellent work on making this code.... @chauduyphanvu. Much appreciated Thank you

I'm on Windows 11 if that matters

I attempted to set both the environment and system variables for DEFAULT_REDDIT_SAVE_LOCATION as shown on the screenshot but the script is unable to recognize the path

image

Also is there a reason the make things complicated and use environment variables to define a path? I'd prefer to edit the settings.json file to include the system directly there like below

"default_save_location": "F:\Reddit Markdown",

Quick suggestion. If you could add another setting which could allow to download embedded pictures on the reddit posts as well would be excellent...

MonsterSe7en commented 2 weeks ago

I got to know about this repository from the reddit page [Script] Save Reddit posts to Obsidian https://www.reddit.com/r/ObsidianMD/comments/104k0om/script_save_reddit_posts_to_obsidian/

It would be excellent if you could convert the code and made an Obsidian Plugin out of it.... I'm confident a lot of people would use it!!

Cheers!!