search

chavi362 / Icy-Tower

An interactive Icy Tower Game built with Java Script, html, and CSS. Let's come to contribute or play!
Other
45 stars 22 forks source link

Minor changes made to the UI #31

Closed KaosElegent closed 9 months ago

KaosElegent commented 9 months ago

I've made the following changes to make the sign-in & sign-up processes easier.

  1. 'Sign-up' was written as 'Sign-in' at a couple of places, which was a bit confusing since both of those have different meanings. ('login' and 'sign-in' were the terms used instead of 'login' and 'sign-up'.
  2. It was assumed that the user would enter their email as the username which wasn't obvious, so that wording was changed in the form.
  3. A maximum limit of 15 characters for passwords seemed unusual since this would limit the strength of their passwords. So that was raised to 35.
  4. Password-related elements in the sign-up form had their event listeners changed from 'change' to the 'input' event type. This ensures a smoother experience while creating the account. This also makes it easier to add additional password rules (at least 1 symbol, letter, number, special character, etc...).
  5. Ran prettier at commit (ce05bfdfbae698eee3a2fc62bb34af3ed9f647b4) as instructed, and added node_modules to the .gitignore.

Most of these are very minor changes which don't affect the functionality but I believe that such changes create a better overall experience.

KaosElegent commented 9 months ago

Adding node_modules to the git ignore was a personal choice, I'm unsure if it's better to keep it on git. (I'm new to open-source and team collaboration)