Thanks and feedback on jwt session

[bdowling]

@chavli thanks for sharing this more complete implementation of a backend restful app. I think you have pulled together a very nice complement of features into this that were helpful to help me improve my own efforts along these lines.

I would like to offer a couple of comments:

• I chose to use flask-restplus in my implementation mainly to get the OpenAPI docs a little more automatically. Adapting your boilerplate to this wasn't too bad. One change however was that in flask_restplus.reqparse the namespace_class is called result_class (used in requestparser.py)
• I'm still trying to sort out the ability to use the Marshmallow models in the schema, it appears a few have patched restplus to work with it. e.g. https://github.com/Jaza/flask-restplus-patched
• I'm not clear your usage of JWT tokens is in the true spirit of JWT, it seems you are largely just doing a stored session hash lookup rather than validating the token. I'm looking around to see if Flask-JWT -Simple or Flask-JWT-Extended (so many derivatives!) may work better for this aspect, not sure if you have looked at those? Some possible other design patterns to look at:
  • https://github.com/blohinn/flask-restplus-full-todo-example-with-jwt
  • https://github.com/USGS-CIDA/flask_restplus_jwt
  • https://github.com/lxc-webpanel/lxc-rest/commit/158c41b060a13594365373c56bda8ca77ec6d87c

In any case, just thought I'd offer some feedback since I did appreciate you posting this. If I find the time I may derive my implementation back to boilerplate as I found this useful..

[chavli]

@bdowling , Thanks for checking it out and I'm glad it helped you learn a few things. I have to admit this repo is undermaintained (actually neglected) and I've been meaning to update it with fixes and new examples.

About the JWT usage, initially, I wasn't sure if I should include any validation code since that's very case-dependent so I kept it pretty basic.

I'll check out the links you shared, and thanks again for the feedback :100: