chavoosh / ndn-mongo-fileserver

An NDN fileserver based on MongoDB
GNU General Public License v3.0
5 stars 2 forks source link

scripts: add auto complete for arrange-data.py #11

Closed wenkaizheng closed 4 years ago

chavoosh commented 4 years ago

Based on a very quick test:

  1. the program is significantly slow. It freezes up unless I press Cntl + C. It looks like a bug or bad implementation.
  2. In the input do not require the parameter. If user passed the parameter (e.g., rtt) use it, otherwise, after figuring out the time range, ask the user what parameter he wants to see.
wenkaizheng commented 4 years ago

I will fix the second problem, for the first one because of the library I used seems to cause a speed problem. I did not see another useful library to support auto-complete. Do you have any suggestions?

chavoosh commented 4 years ago

Do you mean readline package? If so, how does it cause a performance issue?

wenkaizheng commented 4 years ago

I thought it is my problem for implementation, and I have already fix it. now it runs very fast. I will push a new version today.

chavoosh commented 4 years ago

Thanks for removing the bug and fixing the speed issue. Now it seems good.

Here are some problems that need to be fixed:

  1. The input should be non-case sensitive:
    
    > D <tab>
    > Dec/

d Dec/

  1. This seems to be a bug Start time is Dec/10/2019 11:00:06 End time is Dec/10/2019 11:00:14

    two date specific
    no such a session exist
  2. Get the input one by one. This is not correct

    Please type a date range
    You choose one of the network charaistics from jitter, rebuffers, rtt,retx,timeout,nack,segments

    Pay attention to typos and English grammer and punctuations.

  3. In the input when the program asks for the parameter, the auto-completion returns dates which is incorrect. The program needs to support auto-completion for parameters, too.

wenkaizheng commented 4 years ago

For the second one. should there be any session between these two dates? For the third one, what do you mean to get input one by one? Can I have an example? Also, I have a networking exam tomorrow, so I won't be able to work too much today😂.

chavoosh commented 4 years ago

Change the commit message to: scripts: add auto completion to arrange-data.py