search

chaw-bot / toDoList

A to-do list app, enables users to add tasks, edit tasks, cross out tasks and delete tasks
10 stars 0 forks source link

Do I follow JavaScript best practices? #5

Open chaw-bot opened 3 years ago

chaw-bot commented 3 years ago

For this project I used the JavaScript best practices:

https://github.com/chaw-bot/toDoList/blob/31abbc54217951d8e518eabc3b694db2ae78dc39/src/index.js#L46-L52

For the above piece of code, the best practice would be to use === and not ==.

chaw-bot commented 2 years ago

Hi👋🏾 @chaw-bot Good job implementing most of the project's requirements 👏🏾 your App looks good.

✔️ To Highlight ✔️ Kept all JavaScript code in JS files ✔️ Code is clean ✔️ Used arrow functions ✔️ Code is DRY, KISS, and YANGI ✔️ Followed all the HTML & CSS best practices.

Required Changes ♻️

For the above piece of code consider using the best practices which would be to use === and not ==.

Happy coding! 💻

Side note: This was a solo week for me, I had no coding partner.