chaynHQ / bloom-backend

Code for the backend / API of the Bloom service
https://bloom.chayn.co/
MIT License
18 stars 31 forks source link

Create GET /subscription_user endpoint #429

Closed eleanorreem closed 1 month ago

eleanorreem commented 4 months ago

Overview

We want to start breaking up the GET /user/me request and only fetch information on the pages it is needed. This is starting with subscriptions. We also are misusing types across the site so we want to improve the ways of transferring data. Note that we don't want any DTOs to be used in the service, only in the controllers. We are also phasing out all ITypes such as ISubscriptionUser. All formatting needs to happen in the controller. I have labelled this ticket as advanced, not because of the complexity, but because of the confidence needed in controller/service interactions and appropriate types.

Action Items

Resources

Tim-Quattrochi commented 2 months ago

@eleanorreem Can I please take on this issue? thanks.

github-actions[bot] commented 2 months ago

Thank you @Tim-Quattrochi you have been assigned this issue! Please follow the directions in our Contributing Guide. We look forward to reviewing your pull request shortly ✨


Support Chayn's mission? ⭐ Please star this repo to help us find more contributors like you! Learn more about Chayn here and explore our projects. 🌸

Tim-Quattrochi commented 2 months ago

@eleanorreem Just wanted to get some clarification. You said the the service should just return the name, and the controller should return the 'GetSubscriptionUsersDto', this is my return response right now: Screenshot 2024-08-10 at 11 41 15 PM

Tim-Quattrochi commented 2 months ago

Progress: Need to refactor, test more.

Screenshot 2024-08-11 at 5 38 34 AM
kyleecodes commented 2 months ago

@eleanorreem Just wanted to get some clarification. You said the the service should just return the name, and the controller should return the 'GetSubscriptionUsersDto', this is my return response right now: Screenshot 2024-08-10 at 11 41 15 PM

Hi @Tim-Quattrochi thank you for your contribution! Great question. Eleanor is off right now until Monday, I will ping her to come here and answer your question. Thanks for your patience!